KAFKA-19207: Move ForwardingManagerMetrics and ForwardingManagerMetricsTest to server module #19574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…csTest to server module Signed-off-by: PoAn Yang <[email protected]>
chia7712
reviewed
May 1, 2025
| */ | ||
| private final LatencyHistogram remoteTimeMsHist; | ||
|
|
||
| public final MetricName queueLengthName; |
There was a problem hiding this comment.
could we avoid using public member?
| METRIC_GROUP_NAME, | ||
| "The current number of RPCs that are waiting in the broker's forwarding manager queue, waiting to be sent to the controller." | ||
| ); | ||
| metrics.addMetric(queueLengthName, new FuncGauge<>(now -> queueLength.get())); |
Signed-off-by: PoAn Yang <[email protected]>
|
@chia7712 I addressed all comments. Thanks. |
chia7712
reviewed
May 5, 2025
| public final MetricName latencyP999Name; | ||
|
|
||
|
|
||
| public LatencyHistogram(Metrics metrics, String name, String group, long maxLatency) { |
There was a problem hiding this comment.
could you please use private constructor?
| this.latencyP999Name = metrics.metricName(name + ".p999", group); | ||
|
|
||
| sensor.add(new Percentiles( | ||
| 4000, |
There was a problem hiding this comment.
could you please add a static constant for it?
Signed-off-by: PoAn Yang <[email protected]>
chia7712
approved these changes
May 6, 2025
shmily7829
pushed a commit
to shmily7829/kafka
that referenced
this pull request
May 7, 2025
…sTest to server module (apache#19574) 1. Move `ForwardingManagerMetrics` and `ForwardingManagerMetricsTest` to server module. 2. Rewrite them in Java. Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ForwardingManagerMetricsandForwardingManagerMetricsTesttoserver module.
Reviewers: Chia-Ping Tsai [email protected]