MINOR: fix bug in MockConsumer #19627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankvicky
approved these changes
May 3, 2025
|
Wasn't me. Thanks you, co-pilote! (I actually reviewed the PR that introduced it, and missed during review 😞) |
I love copilot too, so please don't replace programmers 😢 |
shmily7829
pushed a commit
to shmily7829/kafka
that referenced
this pull request
May 7, 2025
The setter of `maxPollRecords` wrongly checks the field instead of the argument. Reviewers: Chia-Ping Tsai <[email protected]>, TengYao Chi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: Chia-Ping Tsai [email protected], TengYao Chi
[email protected]