MINOR: introduce structure to keep member assignment with topic Ids #19645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankvicky
reviewed
May 6, 2025
There was a problem hiding this comment.
@lianetm: Thanks for the enhancement!
Love this new structure 😸
| } | ||
|
|
||
| /** | ||
| * Add a new topic (id+name) and partition. This will keep it, and also save references to the topic ID, topic name and partition, |
There was a problem hiding this comment.
Suggested change
| * Add a new topic (id+name) and partition. This will keep it, and also save references to the topic ID, topic name and partition, | |
| * Add a new topic (id+name) and partition. This will keep it, and also save references to the topic ID, topic name and partition. |
frankvicky
reviewed
May 6, 2025
Comment on lines
1443
to
1446
| this.localEpoch = localEpoch; | ||
| this.partitions = new HashMap<>(); | ||
| if (localEpoch == NONE_EPOCH && !topicIdPartitions.isEmpty()) { | ||
| throw new IllegalArgumentException("Local epoch must be set if there are partitions"); | ||
| } |
There was a problem hiding this comment.
Should we consider checking the value before assigning it?
| @@ -376,8 +370,8 @@ protected void processAssignmentReceived(Map<Uuid, SortedSet<Integer>> assignmen | |||
| */ | |||
| private void replaceTargetAssignmentWithNewAssignment(Map<Uuid, SortedSet<Integer>> assignment) { | |||
| currentTargetAssignment.updateWith(assignment).ifPresent(updatedAssignment -> { | |||
| log.debug("Target assignment updated from {} to {}. Member will reconcile it on the next poll.", | |||
| currentTargetAssignment, updatedAssignment); | |||
| log.debug("Member {} updated it's target assignment from {} to {}. Member will reconcile it on the next poll.", | |||
| "be reconciled.", memberId, memberEpoch, MemberState.RECONCILING); | ||
| "to ack a previous reconciliation. \n" + | ||
| "\t\tCurrent assignment: {} \n" + | ||
| "\t\tNew assignment to reconcile: {}\n", |
There was a problem hiding this comment.
Any reason why this is not "Target assignment"? I wonder if there's a subtle difference that I've failed to grasp.
There was a problem hiding this comment.
no reason, it's the Target assignment indeed. Fixed.
|
Thanks for the feedback @frankvicky / @AndrewJSchofield! All comments addressed. |
AndrewJSchofield
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and partitions), to easily access the data as needed. This will be used
in following PR to integrate assignment with topic IDs into the
subscription state.
No changes in logic.
Reviewers: TengYao Chi [email protected], Andrew Schofield
[email protected]