MINOR: Add tests on TxnOffsetCommit and EndTxnMarker protection against invalid producer epoch when TV2 is used #20024
+338
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
dongnuo123
changed the title
chia7712
reviewed
Jun 26, 2025
core/src/test/scala/unit/kafka/server/TxnOffsetCommitRequestTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/server/TxnOffsetCommitRequestTest.scala
Outdated
Show resolved
Hide resolved
dongnuo123
changed the title
|
@FrankYang0529 For EndTxnRequest we already have some integration tests in TransactionTest.scala but I guess we should have one for WriteTxnMarkersRequest to test the protection on the group coordinator side |
core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala
Outdated
Show resolved
Hide resolved
squah-confluent
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds an API level integration test for the producer epoch
verification when processing transactional offset commit and end txn
markers.