KAFKA-19221: Backport to 4.0 #20072
Merged
KAFKA-19221: Backport to 4.0 #20072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurav-narula
commented
Jun 30, 2025
| broker.shutdown(); | ||
|
|
||
| assertEquals(1, broker.config().logDirs().size()); | ||
| String logDir = broker.config().logDirs().head(); |
There was a problem hiding this comment.
This cherry-pick uses logDirs().head() instead of logDirs().get(0)
|
@gaurav-narula I will merge #20102 first |
|
@gaurav-narula could you please sync 4.0 to trigger QA again? |
Log segment closure results in right sizing the segment on disk along with the associated index files. This is specially important for TimeIndexes where a failure to right size may eventually cause log roll failures leading to under replication and log cleaner failures. This change uses `Utils.closeAll` which propagates exceptions, resulting in an "unclean" shutdown. That would then cause the broker to attempt to recover the log segment and the index on next startup, thereby avoiding the failures described above. Reviewers: Omnia Ibrahim <[email protected]>, Jun Rao <[email protected]>, Chia-Ping Tsai <[email protected]>
gaurav-narula
force-pushed
the
KAFKA-19221-4.0-backport
branch
from
eafff7d to
aae3bbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports KAFKA-19221 to 4.0 branch. The patch applied cleanly but there was a build failure in the test due to recent refactoring.