KAFKA-19042 Move PlaintextConsumerTest to client-integration-tests module #20081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
frankvicky
reviewed
Jul 2, 2025
Comment on lines
+1063
to
+1071
| var brokers = cluster.brokers().values(); | ||
| brokers.forEach(broker -> assertNoMetric(broker, "byte-rate", QuotaType.PRODUCE, producerClientId)); | ||
| brokers.forEach(broker -> assertNoMetric(broker, "throttle-time", QuotaType.PRODUCE, producerClientId)); | ||
| brokers.forEach(broker -> assertNoMetric(broker, "byte-rate", QuotaType.FETCH, consumerClientId)); | ||
| brokers.forEach(broker -> assertNoMetric(broker, "throttle-time", QuotaType.FETCH, consumerClientId)); | ||
| brokers.forEach(broker -> assertNoMetric(broker, "request-time", QuotaType.REQUEST, producerClientId)); | ||
| brokers.forEach(broker -> assertNoMetric(broker, "throttle-time", QuotaType.REQUEST, producerClientId)); | ||
| brokers.forEach(broker -> assertNoMetric(broker, "request-time", QuotaType.REQUEST, consumerClientId)); | ||
| brokers.forEach(broker -> assertNoMetric(broker, "throttle-time", QuotaType.REQUEST, consumerClientId)); |
There was a problem hiding this comment.
Could we use a single for-loop here?
There was a problem hiding this comment.
I think this approach is clear enough. However, I’m not sure if using a test case record and adding all test cases into a list is the best approach.
...integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerTest.java
Outdated
Show resolved
Hide resolved
Yunyung
reviewed
Jul 4, 2025
...integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerTest.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Jul 4, 2025
...integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerTest.java
Outdated
Show resolved
Hide resolved
...integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerTest.java
Outdated
Show resolved
Hide resolved
...integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerTest.java
Outdated
Show resolved
Hide resolved
...integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerTest.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Jul 7, 2025
|
|
||
| @Flaky("KAFKA-18031") | ||
| @ClusterTest | ||
| public void testClassicConsumerCloseLeavesGroupOnInterrupt() throws Exception { |
There was a problem hiding this comment.
Could we leave those flaky in the old framework? It helps us to reproduce the failed tests.
| )); | ||
| } | ||
|
|
||
| @Flaky("KAFKA-18031") |
chia7712
approved these changes
Jul 7, 2025
chia7712
reviewed
Jul 7, 2025
| import org.junit.jupiter.api.Assertions._ | ||
| import org.junit.jupiter.api.Timeout | ||
| import org.junit.jupiter.params.ParameterizedTest | ||
| import org.junit.jupiter.params.provider.MethodSource | ||
|
|
||
| import java.util.concurrent.{CompletableFuture, ExecutionException, TimeUnit} | ||
| import java.util.concurrent.ExecutionException | ||
|
|
||
| @Timeout(600) | ||
| class PlaintextConsumerTest extends BaseConsumerTest { |
There was a problem hiding this comment.
it should extend AbstractConsumerTest instead BaseConsumerTest. otherwise, those tests will be executed on both clients-integration-tests and core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Java to rewrite PlaintextConsumerTest by new test infra and move it
to client-integration-tests module.
Reviewers: Jhen-Yung Hsu [email protected], TengYao Chi
[email protected], Chia-Ping Tsai [email protected]