KAFKA-19450: ShareConsumerPerformance does not handle exceptions from consumeMessagesForSingleShareConsumer #20126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewJSchofield
requested changes
Jul 8, 2025
| @@ -153,6 +157,9 @@ private static void consume(List<KafkaShareConsumer<byte[], byte[]>> shareConsum | |||
| // Preserve interrupt status | |||
| Thread.currentThread().interrupt(); | |||
| } | |||
| for (Future<?> future : futures) { | |||
| future.get(1, TimeUnit.MILLISECONDS); | |||
There was a problem hiding this comment.
Is there any point in waiting for 1 ms here? Wouldn't future.get() be as effective?
There was a problem hiding this comment.
Yes, it would be the same. I'll change this code.
AndrewJSchofield
changed the title
AndrewJSchofield
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Within
ShareConsumerPerformance.java, all the share consumers run withwithin an executorService object and when we
perform
executorService.submit(), we do not store this future andexception would be recovered only when we do a future.get() in this
case. I believe this is a shortcoming
in
ShareConsumerPerformance.javawhich needs to be improved.Reviewers: Andrew Schofield [email protected]