Skip to content

MINOR: Tidy up in AlterShareGroupOffsetsHandler #20130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2025

Conversation

AndrewJSchofield
Copy link
Member

@AndrewJSchofield AndrewJSchofield commented Jul 9, 2025

Minor tidying up in AlterShareGroupOffsetsHandler based on review
comment
#20049 (comment).

Reviewers: Jimmy Wang [email protected], Lan Ding
[email protected], TaiJuWu [email protected], Ken Huang
[email protected], Jhen-Yung Hsu [email protected], Chia-Ping
Tsai [email protected]

Copy link
Collaborator

@Yunyung Yunyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. One small comment left

Copy link
Contributor

@DL1231 DL1231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, LGTM!

@chia7712
Copy link
Member

chia7712 commented Jul 9, 2025

the flaky will be resolved by #20121

@chia7712 chia7712 merged commit 7b8a594 into apache:trunk Jul 9, 2025
26 of 28 checks passed
@AndrewJSchofield AndrewJSchofield deleted the alter-sgo-tidy branch July 9, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants