MINOR: Refactor LockUtils and improve comments (follow up to KAFKA-19390) #20131
+19
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
chia7712
approved these changes
Jul 9, 2025
junrao
reviewed
Jul 11, 2025
| // Serializes all index operations that mutate internal state | ||
| // Serializes all index operations that mutate internal state. | ||
| // Readers do not need to acquire this lock because: | ||
| // 1) They only access published entries and are not affected by concurrent writes. |
There was a problem hiding this comment.
How about the following?
Clients only read committed data and are not affected by concurrent appends/truncates. In the rare case, when the data is truncated, the follower could read inconsistent data. The follower has the logic to ignore the inconsistent data through crc and leader epoch.
There was a problem hiding this comment.
Thanks for the feedback. I've updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR performs a refactoring of LockUtils and improves inline comments, as a follow-up to #19961.