MINOR: Fix the handling source topic deletion integration test #20155
+11
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaidenE1
changed the title
github-actions
bot
added
streams
tests
Yunyung
reviewed
Jul 11, 2025
Comment on lines
+138
to
140
| TimeUnit.SECONDS.sleep(5); | ||
| assertThat(calledUncaughtExceptionHandler1.get(), is(true)); | ||
| assertThat(calledUncaughtExceptionHandler2.get(), is(true)); |
There was a problem hiding this comment.
How about doing this instead of always sleeping for a fixed time
Suggested change
| TimeUnit.SECONDS.sleep(5); | |
| assertThat(calledUncaughtExceptionHandler1.get(), is(true)); | |
| assertThat(calledUncaughtExceptionHandler2.get(), is(true)); | |
| TestUtils.waitForCondition( | |
| () -> calledUncaughtExceptionHandler1.get() && calledUncaughtExceptionHandler2.get(), | |
| TIMEOUT, | |
| () -> "......Error Message......" | |
| ); |
| @@ -42,10 +42,13 @@ | |||
| import java.util.Locale; | |||
| import java.util.Properties; | |||
| import java.util.concurrent.atomic.AtomicBoolean; | |||
| import java.util.concurrent.CountDownLatch; | |||
|
|
||
| import static org.apache.kafka.streams.utils.TestUtils.safeUniqueTestName; | ||
| import static org.hamcrest.CoreMatchers.is; | ||
| import static org.hamcrest.MatcherAssert.assertThat; | ||
| import static org.junit.jupiter.api.Assertions.assertTrue; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an integration test error:
In the old version, the
HandlingSouceTopicDeleteIntegrationTestexpects state change toERRORin both old and new protocols, but in the new protocol, we should expectsMissingSourceTopicException.