KAFKA-19459: List internal topics for the user #20157
Open
+15
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c-version-mismatch
…c-version-mismatch
frankvicky
reviewed
Jul 12, 2025
Comment on lines
849
to
850
| printError("Retrieving internal topics is not supported by the broker version. " + | ||
| "Use 'kafka-topics.sh' to list and delete the group's internal topics.", Optional.of(e.getCause())); |
There was a problem hiding this comment.
Should we combine the internal topics message into printError?
Comment on lines
834
to
845
| List<String> internalTopics = new ArrayList<>(); | ||
| try { | ||
| Set<String> allTopics = adminClient.listTopics().names().get(); | ||
| for (String topic : allTopics) { | ||
| for (String groupId : groupIds) { | ||
| if (isInferredInternalTopic(topic, groupId)) { | ||
| internalTopics.add(topic); | ||
| break; | ||
| } | ||
| } | ||
| } | ||
| System.out.println("Internal Topics: (" + String.join(",", internalTopics) + ")."); |
There was a problem hiding this comment.
We could use the stream api to align the style with this whole class.
For example:
Suggested change
| List<String> internalTopics = new ArrayList<>(); | |
| try { | |
| Set<String> allTopics = adminClient.listTopics().names().get(); | |
| for (String topic : allTopics) { | |
| for (String groupId : groupIds) { | |
| if (isInferredInternalTopic(topic, groupId)) { | |
| internalTopics.add(topic); | |
| break; | |
| } | |
| } | |
| } | |
| System.out.println("Internal Topics: (" + String.join(",", internalTopics) + ")."); | |
| String internalTopics; | |
| try { | |
| Set<String> allTopics = adminClient.listTopics().names().get(); | |
| internalTopics = allTopics.stream() | |
| .filter(topic -> groupIds.stream().anyMatch(groupId -> isInferredInternalTopic(topic, groupId))) | |
| .collect(Collectors.joining(",")); | |
| System.out.println("Internal Topics: (" + internalTopics + ")."); |
There was a problem hiding this comment.
Thanks for the comment! Just revised the method:
- use Stream API
- Combine print internal topics in the
printErrormessage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the Kafka Stream group commands, if delete topic requests fail due to version mismatch, user will have to remove the topics manually by first retrieving the relevant internal topics.
To assist the user, the internal topic names are now included as part of the error message, so that the user could delete the internal topics associated with this application directly.
Reviewer: @aliehsaeedii