Remove generics #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…laces that pull this generic through the code base. This is mostly removal of places that try to be generic but are not. This also removes the need for a lot of casts, annotations and <?> generics. Also fix a large number of raw class usages where generic classes such as Map or Class are not used with generics. Explicitly do not touch the APIs we implement (log4j 1.2 etc.).
|
You wanna submit this as a patch on the JIRA tracker? |
|
one more test... :C |
|
looks like it works now :) |
rgoers
pushed a commit
that referenced
this pull request
Jul 29, 2020
* Initial implementation of Redis appender. * Add unit test support for Redis Appender. * Clean up implementation. * Add site documentation and clean up imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the generic from Appender and subsequently change all the places that
pull this generic through the code base. This is mostly removal of places that try
to be generic but are not.