Skip to content

Fix key removal issues in Thread Context #3050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 10, 2024
Merged

Fix key removal issues in Thread Context #3050

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d54265d
Fix key removal issues in Thread Context
vy Oct 2, 2024
91ff32c
Improve `Iterable`-to-`Set` translation
vy Oct 2, 2024
b583161
Decrease visibility in `CloseableThreadContextTest`
vy Oct 9, 2024
edc4f3e
Decrease visibility in `CloseableThreadContextTest` (2nd time)
vy Oct 9, 2024
4668154
Remove `println()` in test
vy Oct 9, 2024
a0ff439
Merge remote-tracking branch 'origin/2.x' into fix/2.x/MDC-remove
vy Oct 10, 2024
df5ec81
Add a `copyAndRemoveAll()` test
vy Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Decrease visibility in CloseableThreadContextTest 
Co-authored-by: Piotr P. Karwasz <[email protected]>
  • Loading branch information
@vy @ppkarwasz
vy and ppkarwasz authored Oct 9, 2024
commit b583161bc45a64c090e3edbcc01afc6bfc4fa549
2 changes: 1 addition & 1 deletion log4j-api-test/src/test/java/org/apache/logging/log4j/CloseableThreadContextTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ public void pushAllWillPushAllValues() {
* @see <a href="https://github.com/apache/logging-log4j2/issues/2946#issuecomment-2382935426">#2946</a>
*/
@Test
public void testAutoCloseableThreadContextPut() {
void testAutoCloseableThreadContextPut() {
try (final CloseableThreadContext.Instance ctc1 = CloseableThreadContext.put("outer", "one")) {
try (final CloseableThreadContext.Instance ctc2 = CloseableThreadContext.put("outer", "two")) {
assertEquals("two", ThreadContext.get("outer"));
Expand Down