LUCENE-10241: Updating OpenNLP to 1.9.4. #448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It would be nice if this was updated to the awesome new OpenNLP 2.x line! |
Contributor
|
@jzonthemtn not sure I have the knowledge or chops to do this upgrade... |
Contributor
Author
I'll push an update! |
9 tasks
Resolved Conflicts: versions.lock versions.props
cpoerschke
approved these changes
Oct 13, 2023
Contributor
cpoerschke
left a comment
cpoerschke
left a comment
There was a problem hiding this comment.
LGTM if we wanted to upgrade to latest 1.9.x ahead of an upgrade to 2.x
Contributor
I'm also interested in this -- #12674 so far, work-in-progress. |
Contributor
|
If there are no objections or concerns I'll aim to merge this sometime next week. (And the upgrade to 2.x can happen as a follow-up pull request.) |
asfgit
pushed a commit
that referenced
this pull request
Nov 17, 2023
(cherry picked from commit c228e4b) Resolved Conflicts: versions.lock versions.props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating OpenNLP dependency to 1.9.4.
#11277
Solution
Updated OpenNLP dependency version.
Tests
Tests passed.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.