[SYNCOPE-1804] Introducing syncope-core-persistence-neo4j #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ilgrosso merged 10 commits into apache:master from ilgrosso:SYNCOPE-1804

Feb 23, 2024

Member

ilgrosso commented Feb 21, 2024 •

edited

Loading

This PR is just the first step to have Syncope Core fully running on Neo4j.

Missing items include at least:

replacing Quartz - see SYNCOPE-1801
refactoring of audit mechanisms to remove log4j for a proper DAO
~~Keymaster: domain, self-keymaster, defaultContent.xml~~
profile to run IT cases

github-advanced-security bot found potential problems

View reviewed changes

...common/src/main/java/org/apache/syncope/core/persistence/common/dao/AbstractAnyMatchDAO.java

+                              List<PlainAttrValue> anyAttrValues = new ArrayList<>();
+                              anyAttrValues.add(anyUtils.newPlainAttrValue());
+                              switch (anyAttrValue) {

Check warning

Code scanning / CodeQL

Dereferenced variable may be null

Variable [anyAttrValue](1) may be null at this access as suggested by [this](2) null guard. Variable [anyAttrValue](1) may be null at this access as suggested by [this](3) null guard.

...nce-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/dao/Neo4jAnySearchDAO.java

+                  }
+                  protected void getQueryForCustomConds(
+                          final AnyTypeKind kind,

Check notice

Code scanning / CodeQL

Useless parameter

The parameter 'kind' is never used.

...nce-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/dao/Neo4jAnySearchDAO.java

+                  protected void getQueryForCustomConds(
+                          final AnyTypeKind kind,
+                          final SearchCond cond,

Check notice

Code scanning / CodeQL

Useless parameter

The parameter 'cond' is never used.

...nce-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/dao/Neo4jAnySearchDAO.java

+                  protected void getQueryForCustomConds(
+                          final AnyTypeKind kind,
+                          final SearchCond cond,
+                          final Map<String, Object> parameters,

Check notice

Code scanning / CodeQL

Useless parameter

The parameter 'parameters' is never used.

...nce-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/dao/Neo4jAnySearchDAO.java

+                          final AnyTypeKind kind,
+                          final SearchCond cond,
+                          final Map<String, Object> parameters,
+                          final boolean not,

Check notice

Code scanning / CodeQL

Useless parameter

The parameter 'not' is never used.

...nce-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/dao/Neo4jAnySearchDAO.java

+                      TextStringBuilder query = new TextStringBuilder("MATCH (n) WHERE ");
+                      plainSchemaDAO.findById(cond.getSchema()).ifPresentOrElse(
+                              schema -> fillAttrQuery(

Check notice

Code scanning / CodeQL

Useless parameter

The parameter 'schema' is never used.

.../src/main/java/org/apache/syncope/core/persistence/api/entity/policy/PolicyUtilsFactory.java

-                  PolicyUtils getInstance(Policy policy);
+                  public PolicyUtils getInstance(final Policy policy) {
+                      PolicyType type;
+                      if (policy instanceof AccountPolicy) {

Check notice

Code scanning / CodeQL

Chain of 'instanceof' tests

This if block performs a chain of 9 type tests - consider alternatives, e.g. polymorphism or the visitor pattern.

...common/src/main/java/org/apache/syncope/core/persistence/common/dao/AbstractAnyMatchDAO.java


		protected abstract void relationshipFieldMatches(PropertyDescriptor pd, AnyCond cond, PlainSchema schema);

		protected boolean matches(final Any<?> any, final AnyCond cond, final boolean not) {

Check notice

Code scanning / CodeQL

Confusing overloading of methods

Method AbstractAnyMatchDAO.matches(..) could be confused with overloaded method [matches](1), since dispatch depends on static types.

...nce-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/dao/Neo4jAnySearchDAO.java

+                      }
+                  }
+                  protected Pair<String, String> getQuery(

Check notice

Code scanning / CodeQL

Confusing overloading of methods

Method Neo4jAnySearchDAO.getQuery(..) could be confused with overloaded method [getQuery](1), since dispatch depends on static types.

...istence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/Neo4jDomainHolder.java

+                  private final Map<String, Driver> domains = new ConcurrentHashMap<>();
+                  @Override
+                  public Map<String, Driver> getDomains() {

Check notice

Code scanning / CodeQL

Exposing internal representation

getDomains exposes the internal representation stored in field domains. The value may be modified [after this call to getDomains](1).

ilgrosso marked this pull request as draft

February 21, 2024 12:49

ilgrosso added 5 commits

February 22, 2024 11:31


          [SYNCOPE-1804] Introducing syncope-core-persistence-neo4j

15d4440


          Fixing JPA JSON tests

bf3ef2b


          Fix ITs

307bdcc


          Fixing Elasticsearch and OpenSearch

af08e3e


          Fix pgjsonb with audit and restore RoleITCase#create

4376a9e

ilgrosso force-pushed the SYNCOPE-1804 branch from d2834a8 to 4376a9e Compare

February 22, 2024 16:12


          upgrades

4310fd7

ilgrosso marked this pull request as ready for review

February 23, 2024 05:42

ilgrosso added 3 commits

February 23, 2024 07:46


          How cool is to work with bad assumptions and final classes?

bbc0a36


          Keymaster support for JPA or Neo4j domain definition

d6bbe59

fix

bd21613

github-advanced-security bot found potential problems

View reviewed changes

...er/client-api/src/main/java/org/apache/syncope/common/keymaster/client/api/model/Domain.java

                   }
-                  public String getOrm() {
-                      return orm;
+                  public void setDiscriminator(final String discriminator) {

Check notice

Code scanning / CodeQL

Useless parameter

The parameter 'discriminator' is never used.


          Support for Neo4j domain definition in Console

7174fae

ilgrosso merged commit c9072b6 into apache:master

ilgrosso deleted the SYNCOPE-1804 branch

February 23, 2024 14:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet