This repository was archived by the owner on Nov 8, 2024. It is now read-only.
Changes to minim-api-description #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pksunkara
commented
Nov 28, 2018
| @@ -9,7 +9,8 @@ | |||
| "release": "lerna publish", | |||
| "release:force": "lerna publish --force-publish", | |||
| "test": "lerna exec --scope='*' -- npm run test", | |||
| "lint": "lerna exec --scope='*' -- npm run lint" | |||
| "lint": "lerna exec --scope='*' -- npm run lint", | |||
| "cover": "exit 0" | |||
There was a problem hiding this comment.
This will be implemented later
kylef
reviewed
Nov 28, 2018
| @@ -21,6 +22,6 @@ | |||
| "mocha": "^5.0.2" | |||
| }, | |||
| "engines": { | |||
| "node": ">=4" | |||
| "node": ">=6" | |||
There was a problem hiding this comment.
The CHANGELOG.md file from the repo seems to be missing, We should mark a breaking change that Node 4 support was removed.
pksunkara
changed the title
pksunkara
force-pushed
the
pksunkara/changes
branch
2 times, most recently
from
d34f104 to
91390b2
Compare
kylef
suggested changes
Nov 29, 2018
pksunkara
force-pushed
the
pksunkara/changes
branch
from
91390b2 to
a276b7a
Compare
kylef
approved these changes
Nov 29, 2018
pksunkara
added a commit
that referenced
this pull request
Nov 30, 2018
Fix CHANGELOG format consistency
pksunkara
pushed a commit
that referenced
this pull request
Dec 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the default github's .gitignore for Node.js