asyncThrowingChannel: fixes potential crashes when no more awaiting #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes crashes where the state is "awaiting" with no more awaiting clients. The state is now set to .idle to reflect the reality.
phausler
approved these changes
Apr 21, 2022
Member
phausler
left a comment
phausler
left a comment
There was a problem hiding this comment.
Yea, same fix, same previous caveat that we need to follow up with some way of validating this in tests; looks right to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the sister from this one #143 but for
AsyncThrowingChannelthat suffers from the very same issue.The issue is described here: #142
Before this PR, an
AsyncThrowingChannelcould crash in the following context:AsyncThrowingChannelis being awaitedAn issue has already been created to track the implementation of unit tests to ensure non regression: #148