Remove Sendable constraint for AsyncChain2Sequence
#213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Motivation We want to remove any `Sendable` constraints on iterators since they ought to not be passed between `Task`s. # Modification Explicitly mark the `AsyncChain2Sequence` to be not `Sendable`. # Result Nobody can make this `Sendable`.
Member
|
I think this conditional conformance actually works in all cases; multicast will still maintain that behavior, broadcast will also maintain that behavior too. All that is stored per state is the iterators and derived state from those. |
phausler
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to remove any
Sendableconstraints on iterators since they ought to not be passed betweenTasks.Modification
Explicitly mark the
AsyncChain2Sequenceto be notSendable.Result
Nobody can make this
Sendable.