-
Notifications
You must be signed in to change notification settings - Fork 499
Revise CI running of conformance tests. #1901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The questions on this in my mind are:
ps - we could also update the |
72efa6f to
95891c8
Compare
IMO it's fine if we run the conformance tests only with the latest Swift release. |
Amended. Up to you all on if you want to make this new check required also. |
e7be361 to
ad8f739
Compare
|
@Lukasa @FranzBusch ping |
- Have the `Makefile` provide better messaging in the conformance runners isn't found. - Have `build.yml` run the conformance tests as it is in the protobuf submodule. - Revise the cron based conformance run to be a protobuf HEAD run, so it happens on every PR and still happens on a cron as an early signal for when something might need attention.
ad8f739 to
8598595
Compare
|
@FranzBusch @Lukasa I went ahead and landed this, can one of you make the new step required for PRs since we probably want to ensure the conformance tests are always passing? |
Makefileprovide better messaging in the conformance runners isn't found.build.ymlrun the conformance tests as it is in the protobuf submodule.