Skip to content

Feat: Bash support #9575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 25, 2025
Merged

Feat: Bash support #9575

merged 5 commits into from
Mar 25, 2025

Conversation

Meldiron
Copy link
Contributor

@Meldiron Meldiron commented Mar 25, 2025

What does this PR do?

Uses bash, since OPR v5 now supports it. This allows addition of docs templates that relay on hidden files

Test Plan

Manual QA with templates

Related PRs and Issues

x

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Summary by CodeRabbit

  • Chores
    • Updated script execution commands to consistently use bash for framework configuration and site build processes.
    • Upgraded image versions for appwrite-console and openruntimes-executor services in the Docker configuration.
    • Updated dependency version for appwrite/php-runtimes to a newer version series.
  • Tests
    • Adjusted test setup commands to align with the updated bash usage for script execution.

Copy link

coderabbitai bot commented Mar 25, 2025

Walkthrough

This pull request updates command strings in configuration and test files to replace the use of sh with bash. In the configuration files (app/config/frameworks.php and app/config/templates/site.php), commands such as bundleCommand, startCommand, and buildCommand have been modified. Similarly, in the end-to-end test file, the command used in the testScopes method has been updated to use bash for setting up the function environment. Additionally, the docker-compose.yml file has been updated to reflect new image versions for two services. The composer.json file also updates the version constraint for a package. No changes were made to public entity declarations.

Changes

File(s) Change Summary
app/config/frameworks.php, app/config/templates/site.php Replaced instances of sh with bash in command definitions (bundleCommand, startCommand, and buildCommand) for various frameworks including Analog, Angular, Next.js, Nuxt, React, SvelteKit, etc.
tests/e2e/.../FunctionsCustomServerTest.php Updated the command in the testScopes method from sh setup.sh && composer install to bash setup.sh && composer install to execute the setup script using bash.
docker-compose.yml Updated image versions for appwrite-console from 5.3.0-sites-rc.28 to 5.3.0-sites-rc.30 and for openruntimes-executor from 0.7.12 to 0.7.13.
composer.json Changed the version constraint for appwrite/php-runtimes from "0.18.*" to "0.19.*".

Poem

I’m a rabbit bounding through lines of code,
Swapping sh for bash on a merry new road.
Commands jump ahead with a brighter tone,
In every script and test, the change is shown.
Hopping happily, I cheer each tweak – code magic in every byte! 🐇✨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0295dfc and 708b627.

⛔ Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • composer.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • composer.json
⏰ Context from checks skipped due to timeout of 90000ms (19)
  • GitHub Check: E2E Service Test (Storage)
  • GitHub Check: E2E Service Test (Sites)
  • GitHub Check: E2E Service Test (Locale)
  • GitHub Check: E2E Service Test (Teams)
  • GitHub Check: E2E Service Test (Projects)
  • GitHub Check: E2E Service Test (Proxy)
  • GitHub Check: E2E Service Test (Webhooks)
  • GitHub Check: E2E Service Test (Users)
  • GitHub Check: E2E Service Test (Functions)
  • GitHub Check: E2E Service Test (Realtime)
  • GitHub Check: E2E Service Test (FunctionsSchedule)
  • GitHub Check: E2E Service Test (GraphQL)
  • GitHub Check: E2E Service Test (Health)
  • GitHub Check: E2E Service Test (Account)
  • GitHub Check: E2E Service Test (Avatars)
  • GitHub Check: E2E Service Test (Console)
  • GitHub Check: E2E Service Test (Databases)
  • GitHub Check: Benchmark
  • GitHub Check: Unit Test

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Mar 25, 2025

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
binutils 2.42-r0 CVE-2025-0840 HIGH
libexpat 2.6.4-r0 CVE-2024-8176 HIGH
libxml2 2.12.7-r0 CVE-2024-56171 HIGH
libxml2 2.12.7-r0 CVE-2025-24928 HIGH
libxml2 2.12.7-r0 CVE-2025-27113 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link

github-actions bot commented Mar 25, 2025

✨ Benchmark results

  • Requests per second: 916
  • Requests with 200 status code: 164,860
  • P99 latency: 0.204974236

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 916 1,267
200 164,860 228,021
P99 0.204974236 0.145878727

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
composer.json (1)

47-47: Validate Dependency Version Aliasing for Bash Support.
The version constraint change for "appwrite/php-runtimes" now points to the development branch with aliasing ("dev-feat-bash-support as 0.19.0"). This change is in-line with using the new Bash support enhancements. Please ensure that:

  • The stability of the development branch is verified.
  • No downstream version conflicts occur with dependent packages.
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 524ce87 and 0295dfc.

⛔ Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • composer.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (20)
  • GitHub Check: E2E Service Test (Migrations)
  • GitHub Check: E2E Service Test (Webhooks)
  • GitHub Check: E2E Service Test (VCS)
  • GitHub Check: E2E Service Test (Teams)
  • GitHub Check: E2E Service Test (Storage)
  • GitHub Check: E2E Service Test (Projects)
  • GitHub Check: E2E Service Test (GraphQL)
  • GitHub Check: E2E Service Test (Sites)
  • GitHub Check: E2E Service Test (Proxy)
  • GitHub Check: E2E Service Test (FunctionsSchedule)
  • GitHub Check: E2E Service Test (Realtime)
  • GitHub Check: E2E Service Test (Locale)
  • GitHub Check: E2E Service Test (Functions)
  • GitHub Check: E2E Service Test (Health)
  • GitHub Check: E2E Service Test (Avatars)
  • GitHub Check: E2E Service Test (Console)
  • GitHub Check: E2E Service Test (Databases)
  • GitHub Check: Benchmark
  • GitHub Check: Unit Test
  • GitHub Check: scan

@Meldiron Meldiron merged commit 95ba881 into feat-sites Mar 25, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants