Skip to content

[Compiler-V2] Test case for a bug in the exhaustiveness checker #14297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

fEst1ck
Copy link
Contributor

@fEst1ck fEst1ck commented Aug 16, 2024

Description

Add a transactional test to showcase the bug in #14296

Copy link

trunk-io bot commented Aug 16, 2024

⏱️ 2h 21m total CI duration on this PR
Job Cumulative Duration Recent Runs
forge-compat-test / forge 18m 🟩
forge-e2e-test / forge 18m 🟩
rust-move-unit-coverage 10m 🟩
rust-move-unit-coverage 9m 🟩
rust-move-tests 9m 🟩
test-target-determinator 9m 🟩🟩
execution-performance / test-target-determinator 8m 🟩🟩
rust-move-tests 8m 🟩
rust-move-tests 8m 🟩
check 8m 🟩🟩
rust-move-unit-coverage 7m 🟩
rust-cargo-deny 5m 🟩🟩🟩
general-lints 5m 🟩🟩🟩
rust-doc-tests 5m 🟩
check-dynamic-deps 5m 🟩🟩🟩🟩
rust-doc-tests 5m 🟩
semgrep/ci 2m 🟩🟩🟩🟩
file_change_determinator 37s 🟩🟩🟩
file_change_determinator 34s 🟩🟩🟩
permission-check 18s 🟩🟩🟩🟩
file_change_determinator 18s 🟩🟩
execution-performance / single-node-performance 18s 🟩🟩
forge-framework-upgrade-test / forge 18s 🟩🟩
permission-check 14s 🟩🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩
permission-check 9s 🟩🟩🟩🟩
determine-docker-build-metadata 9s 🟩🟩
permission-check 6s 🟩🟩
Backport PR 4s 🟥
permission-check 4s 🟩
rust-move-tests 1s

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 9s 19m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.3%. Comparing base (a8cd9fa) to head (76f29f4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #14297       +/-   ##
===========================================
- Coverage    71.8%    59.3%    -12.6%     
===========================================
  Files        2360      832     -1528     
  Lines      471980   202773   -269207     
===========================================
- Hits       339031   120265   -218766     
+ Misses     132949    82508    -50441     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fEst1ck fEst1ck enabled auto-merge (squash) August 16, 2024 16:32

This comment has been minimized.

This comment has been minimized.

@fEst1ck fEst1ck force-pushed the match-exhaust-bug branch from d07cc32 to 8058b3e Compare August 16, 2024 16:49

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 8058b3e7c1d55556e057006619a14ccd00e0a075

two traffics test: inner traffic : committed: 12142.82 txn/s, latency: 3277.12 ms, (p50: 3000 ms, p90: 3600 ms, p99: 4800 ms), latency samples: 4616960
two traffics test : committed: 99.97 txn/s, latency: 2858.41 ms, (p50: 2700 ms, p90: 3200 ms, p99: 8400 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.239, avg: 0.225", "QsPosToProposal: max: 0.392, avg: 0.350", "ConsensusProposalToOrdered: max: 0.332, avg: 0.321", "ConsensusOrderedToCommit: max: 0.799, avg: 0.740", "ConsensusProposalToCommit: max: 1.110, avg: 1.061"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.60s no progress at version 1749998 (avg 0.23s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 7.70s no progress at version 1749996 (avg 6.61s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> 8058b3e7c1d55556e057006619a14ccd00e0a075

Compatibility test results for d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> 8058b3e7c1d55556e057006619a14ccd00e0a075 (PR)
1. Check liveness of validators at old version: d1bf834728a0cf166d993f4728dfca54f3086fb0
compatibility::simple-validator-upgrade::liveness-check : committed: 10779.51 txn/s, latency: 3128.83 ms, (p50: 2400 ms, p90: 6100 ms, p99: 13600 ms), latency samples: 356140
2. Upgrading first Validator to new version: 8058b3e7c1d55556e057006619a14ccd00e0a075
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7102.38 txn/s, latency: 3848.12 ms, (p50: 4100 ms, p90: 4500 ms, p99: 4600 ms), latency samples: 135160
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7237.19 txn/s, latency: 4344.60 ms, (p50: 4400 ms, p90: 6700 ms, p99: 6900 ms), latency samples: 241280
3. Upgrading rest of first batch to new version: 8058b3e7c1d55556e057006619a14ccd00e0a075
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7086.04 txn/s, latency: 3774.99 ms, (p50: 4000 ms, p90: 5200 ms, p99: 5300 ms), latency samples: 127320
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7122.63 txn/s, latency: 4410.15 ms, (p50: 4300 ms, p90: 6800 ms, p99: 7000 ms), latency samples: 237020
4. upgrading second batch to new version: 8058b3e7c1d55556e057006619a14ccd00e0a075
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10745.45 txn/s, latency: 2608.59 ms, (p50: 2800 ms, p90: 3100 ms, p99: 3200 ms), latency samples: 195420
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10137.48 txn/s, latency: 3213.60 ms, (p50: 3000 ms, p90: 4400 ms, p99: 5000 ms), latency samples: 341680
5. check swarm health
Compatibility test for d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> 8058b3e7c1d55556e057006619a14ccd00e0a075 passed
Test Ok

@fEst1ck fEst1ck merged commit cf53ca3 into aptos-labs:main Aug 16, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants