Skip to content

Docs: Formatting #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Dec 5, 2018
Merged

Docs: Formatting #240

merged 21 commits into from
Dec 5, 2018

Conversation

Simran-B
Copy link
Contributor

@Simran-B Simran-B commented Dec 4, 2018

No description provided.

@Simran-B Simran-B self-assigned this Dec 4, 2018
@Simran-B Simran-B requested a review from hkernbach December 4, 2018 12:54
@Simran-B Simran-B requested review from maxkernbach and removed request for hkernbach December 4, 2018 17:17
maxkernbach
maxkernbach approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@maxkernbach maxkernbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Did you use a script to format the text/code sections?

@Simran-B
Copy link
Contributor Author

Simran-B commented Dec 5, 2018

@maxkernbach: No, I tried to re-format something with a regex, but it didn't work as expected in vscode. I ended up doing it manually and case by case (I checked the current online version to see where code examples were too wide = scrollbars and fixed these)

sleto-it
sleto-it approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@sleto-it sleto-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do NOT change any code in a doc PR unless strictly strictly needed (it was not in this case). Rather open different PR with the code changes

@sleto-it sleto-it merged commit f0b7625 into master Dec 5, 2018
@BCaxelbecker BCaxelbecker deleted the documentation/2018-12-04 branch January 30, 2019 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxkernbach maxkernbach maxkernbach approved these changes

@sleto-it sleto-it sleto-it approved these changes

Assignees

@Simran-B Simran-B

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Simran-B @maxkernbach @sleto-it