Extend functionality to work with pure enums #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stancl
reviewed
Mar 14, 2022
stancl
reviewed
Mar 14, 2022
stancl
reviewed
Mar 14, 2022
stancl
reviewed
Mar 14, 2022
stancl
reviewed
Mar 14, 2022
Altered `::values()` to act like `::names()` for backed enums, code style fixes, general cleanups
samlev
force-pushed
the
feature/pureEnums
branch
from
01bb019 to
dea16e4
Compare
stancl
reviewed
Mar 23, 2022
| ### Options | ||
|
|
||
| This helper returns an associative array of case names and values. | ||
| This helper returns an associative array of case names and values for backed enums, or a list of names for pure enums (making this functionally equivalent to [`::names()`](#names) for pure Enums). |
Member
There was a problem hiding this comment.
I'll merge this now, but just want to confirm: for pure enums, we're using names for everything, right?
Meaning, names, values, options all return the names. And the internal indices aren't used for anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the Enum traits to also work in a meaninful manner with "Pure" enums, as well as Backed Enums.
A couple of the methods kind of "repeat" functionality, but this makes pure enums as useful as string-backed enums, where the string value is equivalent to the case name.