Skip to content

Fix for ESP32 3.x NetworkClient, Client interface #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix for ESP32 3.x NetworkClient, Client interface #180

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b340454
patch for esp32 NetworkClient and Client interfaces
brentru Sep 9, 2024
770bc04
include guard
brentru Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
include guard
  • Loading branch information
@brentru
brentru committed Sep 9, 2024
commit 770bc04799f7f342f978db019933a7c7899d7067
6 changes: 6 additions & 0 deletions src/ArduinoHttpClient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@
#ifndef ArduinoHttpClient_h
#define ArduinoHttpClient_h

#if defined(ESP_IDF_VERSION)
#if ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(5, 0, 0)
#define HAS_ESP_IDF_5
#endif
#endif

#include "HttpClient.h"
#include "WebSocketClient.h"
#include "URLEncoder.h"
Expand Down
2 changes: 1 addition & 1 deletion src/HttpClient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ class HttpClient : public Client
// Inherited from Client
virtual int connect(IPAddress ip, uint16_t port) { return iClient->connect(ip, port); };
virtual int connect(const char *host, uint16_t port) { return iClient->connect(host, port); };
#ifdef ARDUINO_ARCH_ESP32
#ifdef HAS_ESP_IDF_5
virtual int connect(const char *host, uint16_t port, int32_t timeout){ return iClient->connect(host, port, timeout); };
virtual int connect(IPAddress ip, uint16_t port, int32_t timeout){ return iClient->connect(ip, port, timeout); };
#endif
Expand Down
Loading