This repository was archived by the owner on Jul 15, 2024. It is now read-only.
fix: reap zombie processes in argocd-applicationset-controller pod using tini #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing tini Co-authored-by: Erkan Zileli <[email protected]>
|
|
wtam2018
approved these changes
Jan 11, 2022
Collaborator
wtam2018
left a comment
wtam2018
left a comment
There was a problem hiding this comment.
LGTM
thanks @hcelaloner
ishitasequeira
pushed a commit
to ishitasequeira/applicationset
that referenced
this pull request
Jan 11, 2022
…ing tini (argoproj#453) Co-authored-by: Erkan Zileli <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #452
Inspired by argoproj/argo-cd#3721, tried to use tini to reap zombie processes
Co-authored-by: Erkan Zileli [email protected]