Skip to content

ci: Optimize latency and set SP1_DEV #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2024
Merged

ci: Optimize latency and set SP1_DEV #75

merged 2 commits into from
Jun 24, 2024

Conversation

@huitseeker
Copy link
Contributor

@huitseeker huitseeker commented Jun 24, 2024 •
edited
Loading

  • Modified the description for the 'perf' input in GitHub action to optimize CI latency rather than performance.
  • Implemented setting SP1_DEV, when 'perf' input is set to true.
  • fixes fix SP1_DEV for nightly CI #42.

@huitseeker huitseeker requested a review from samuelburnham June 24, 2024 07:54
@huitseeker huitseeker marked this pull request as ready for review June 24, 2024 07:55
wwared
wwared previously approved these changes Jun 24, 2024
View reviewed changes
@wwared
Copy link
Contributor

wwared commented Jun 24, 2024

Apparently setting SP1_DEV=true breaks test_verifier_export, I'll try to fix it. The check-aptos-lc-compiles failure is due to an expired CI token

@huitseeker @wwared
ci: Optimize latency and set SP1_DEV
33089d5 
- Modified the description for the 'perf' input in GitHub action to optimize CI latency rather than performance.
- Implemented addition of a new environment variable, SP1_DEV=1, when 'perf' input is set to true.
- fixes #42.
@wwared
Copy link
Contributor

wwared commented Jun 24, 2024

@huitseeker, @samuelburnham:

After this PR, the two longest tests in the main CI flow for PRs are:

  • [1011.939s] sphinx-prover tests::test_e2e
  • [ 705.051s] sphinx-sdk artifacts::tests::test_verifier_export

We can ignore those two tests to speed up CI in the future if desired. The slowness seems to be mainly because of the plonk artifact/circuit generation, which is slow even with SP1_DEV=true

@wwared wwared merged commit 9bf6f9e into dev Jun 24, 2024
@wwared wwared deleted the sp1_dev branch June 24, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelburnham samuelburnham Awaiting requested review from samuelburnham

2 more reviewers

@wwared wwared wwared approved these changes

@tchataigner tchataigner tchataigner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix SP1_DEV for nightly CI

4 participants

@huitseeker @wwared @tchataigner