Skip to content

Add optional serde serialization support #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2020
Merged

Conversation

9prady9
Copy link
Member

@9prady9 9prady9 commented Sep 16, 2020

  • Update ci to run serde tests
  • Add serialization support for Enums
  • Structs with serde support added
    • Array
    • Dim4
    • Seq
    • RandomEngine
  • Structs without serde support
    • Features - currently not possible as af_features can't be recreated from individual af_arrays with current upstream API
    • Indexer - not possible with current API. Also, any subarray when fetched to host for serialization results in separate owned copy this making serde support for this unnecessary.
    • Callback
    • Event
    • Window

Fixes #221

- Update ci to run serde tests
- Add serialization support for Enums except the enum `arrayfire::Scalar`
- Structs with serde support added
    - [x] Array
    - [x] Dim4
    - [x] Seq
    - [x] RandomEngine
- Structs without serde support
    - Features - currently not possible as `af_features` can't be recreated
      from individual `af_arrays` with current upstream API
    - Indexer - not possible with current API. Also, any subarray when fetched
      to host for serialization results in separate owned copy this making serde
      support for this unnecessary.
    - Callback
    - Event
    - Window
@9prady9 9prady9 merged commit 00067c8 into arrayfire:master Oct 27, 2020
@9prady9 9prady9 deleted the serde branch October 27, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Serialization and deserialization using serde
1 participant