Skip to content

feat: disable tls-resumption for tls jobs #2073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Mar 14, 2025
Merged

feat: disable tls-resumption for tls jobs #2073

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
096e154
try try
DeagleGross Mar 12, 2025
6a85f7f
disable tls res
DeagleGross Mar 12, 2025
b27390e
log!
DeagleGross Mar 12, 2025
d0afe05
properly configure ntsh for tls resumption
DeagleGross Mar 12, 2025
0475ea9
change log
DeagleGross Mar 13, 2025
59bfddc
logs
DeagleGross Mar 13, 2025
256dcc5
see more ?
DeagleGross Mar 13, 2025
d81b2bb
cleanup
DeagleGross Mar 13, 2025
98064cc
try with flag and expxlicit control
DeagleGross Mar 13, 2025
5be6f5d
log to see why not applied
DeagleGross Mar 13, 2025
64b8ad5
without sessionid?
DeagleGross Mar 13, 2025
fe2ed7f
remove log
DeagleGross Mar 13, 2025
4cc51b7
okay lets remove tmp
DeagleGross Mar 13, 2025
f0975b8
pwsh
DeagleGross Mar 13, 2025
ad565d5
do in cmd
DeagleGross Mar 13, 2025
1c9f10c
try!
DeagleGross Mar 13, 2025
e23c2af
try!
DeagleGross Mar 13, 2025
d097bb6
rerun!
DeagleGross Mar 13, 2025
2c6c777
prepare script
DeagleGross Mar 13, 2025
ccbd752
changes!
DeagleGross Mar 13, 2025
570e4d2
run run
DeagleGross Mar 13, 2025
c46943c
ignore error
DeagleGross Mar 13, 2025
4969fe4
fix quotes
DeagleGross Mar 13, 2025
6791d8f
fix names
DeagleGross Mar 13, 2025
e71dd98
disable tls resume for kestrel
DeagleGross Mar 14, 2025
ad771c0
fix !
DeagleGross Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
run run
  • Loading branch information
@DeagleGross
DeagleGross committed Mar 13, 2025
commit 570e4d2c36474d4dc741380265be12a586145139
4 changes: 2 additions & 2 deletions scenarios/tls.benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ variables:

# these scripts allow to disable (or rollback changes) to the SChannel registry
# this allows to disable TLS resumption on windows level
disableTlsResumptionScript: powershell -Command "New-ItemProperty 'HKLM:\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\' -Name MaximumCacheSize -PropertyType DWord -Value 0; New-ItemProperty 'HKLM:\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\' -Name ServerCacheTime -PropertyType DWord -Value 0; Restart-Service -Name Http -Force; Write-Host 'Disabled TLS Resumption'"
rollbackTlsResumptionScript: powershell -Command "Remove-ItemProperty -Path "HKLM:\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL" -Name ServerCacheTime -ErrorAction Ignore; Remove-ItemProperty -Path "HKLM:\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL" -Name EnableSessionTicket -ErrorAction Ignore; Restart-Service -Name Http -Force; Write-Host 'Rollbacked HTTP.SYS'"
disableTlsResumptionScript: powershell -Command "New-ItemProperty 'HKLM:\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\' -Name MaximumCacheSize -PropertyType DWord -Value 0; New-ItemProperty 'HKLM:\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\' -Name ServerCacheTime -PropertyType DWord -Value 0; Restart-Service -Name Http -Force;"
rollbackTlsResumptionScript: powershell -Command "Remove-ItemProperty -Path "HKLM:\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL" -Name ServerCacheTime -ErrorAction Ignore; Remove-ItemProperty -Path "HKLM:\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL" -Name EnableSessionTicket -ErrorAction Ignore; Restart-Service -Name Http -Force;"

jobs:
httpSysServer:
Expand Down