Skip to content

fix: rejection host header validation scenarios #2091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
May 20, 2025
Merged

fix: rejection host header validation scenarios #2091

Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
96b2545
try
DeagleGross May 7, 2025
4b3ed06
configure host
DeagleGross May 8, 2025
d1c1723
http client
DeagleGross May 8, 2025
1408edb
push log
DeagleGross May 8, 2025
bfb3fdb
tmp enable logging
DeagleGross May 8, 2025
4b83f54
and microsoft logging enable
DeagleGross May 8, 2025
75ee7de
we dont need httpS here?
DeagleGross May 8, 2025
2289f92
back to https due to server setup
DeagleGross May 8, 2025
a2aa6e7
no logging
DeagleGross May 8, 2025
1b8ae84
definitely invalid encoded url
DeagleGross May 12, 2025
0af56a4
httpclient for http.sys jobs
DeagleGross May 12, 2025
d5a9511
try with 2048 public key length explicitly
DeagleGross May 12, 2025
22165b3
try logging
DeagleGross May 13, 2025
3711bbd
this?
DeagleGross May 13, 2025
8b697b8
for debug
DeagleGross May 13, 2025
64d7d5d
set url prefixes
DeagleGross May 14, 2025
aa7349a
log host
DeagleGross May 14, 2025
65cf5dc
fix
DeagleGross May 14, 2025
59afb4a
enable htpt.sys hostname!
DeagleGross May 14, 2025
bf8b9d4
cover enable host validation for kestrel
DeagleGross May 14, 2025
52feb62
try with full message
DeagleGross May 14, 2025
c4ba140
review
DeagleGross May 14, 2025
096d307
Merge branch 'main' into dmkorolev/rejection
DeagleGross May 14, 2025
0503a38
try ith other hostname
DeagleGross May 14, 2025
4e0b7b8
Merge branch 'dmkorolev/rejection' of https://github.com/DeagleGross/…
DeagleGross May 14, 2025
de2c192
try wrk
DeagleGross May 20, 2025
45ce05a
comment out for test
DeagleGross May 20, 2025
c4382aa
back
DeagleGross May 20, 2025
a1424ab
review
DeagleGross May 20, 2025
fc06504
try wrk2?
DeagleGross May 20, 2025
8ad0658
no wrk2
DeagleGross May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
no wrk2
  • Loading branch information
@DeagleGross
DeagleGross committed May 20, 2025
commit 8ad0658cb958bfbe0e28df602f248931ca224422
5 changes: 2 additions & 3 deletions scenarios/rejection.benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ imports:
- https://raw.githubusercontent.com/dotnet/crank/main/src/Microsoft.Crank.Jobs.Bombardier/bombardier.yml
- https://raw.githubusercontent.com/dotnet/crank/main/src/Microsoft.Crank.Jobs.HttpClient/httpclient.yml
- https://raw.githubusercontent.com/dotnet/crank/main/src/Microsoft.Crank.Jobs.Wrk/wrk.yml
- https://raw.githubusercontent.com/dotnet/crank/main/src/Microsoft.Crank.Jobs.Wrk2/wrk2.yml
- https://github.com/aspnet/Benchmarks/blob/main/scenarios/aspnet.profiles.yml?raw=true

variables:
Expand Down Expand Up @@ -84,7 +83,7 @@ scenarios:
variables:
httpSysUrlPrefix: "https://testserver:{{serverPort}}"
load:
job: wrk2
job: wrk
variables:
path: /hello-world
connections: 32
Expand Down Expand Up @@ -123,7 +122,7 @@ scenarios:
variables:
enableHostHeaderValidation: true
load:
job: wrk2
job: wrk
variables:
path: /hello-world
connections: 32
Expand Down
Loading