This repository was archived by the owner on Nov 20, 2018. It is now read-only.
Migrate from xproj to csproj #768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemcmaster
suggested changes
Feb 2, 2017
| <PackageReference Include="System.Text.Encodings.Web" Version="4.4.0-*" /> | ||
| </ItemGroup> | ||
| <ItemGroup Condition=" '$(TargetFramework)' == 'net451' "> | ||
| <Reference Include="System.Globalization" /> |
There was a problem hiding this comment.
Is the a PackageReference we can use for this instead? cref https://github.com/aspnet/Coherence-Signed/issues/400
| <PackageReference Include="System.Buffers" Version="4.4.0-*" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <Folder Include="Properties\" /> |
There was a problem hiding this comment.
Nit: not required, can remove
| <PackageReference Include="System.Security.Principal" Version="4.4.0-*" /> | ||
| </ItemGroup> | ||
| <ItemGroup Condition=" '$(TargetFramework)' == 'net451' "> | ||
| <Reference Include="System" /> |
There was a problem hiding this comment.
Redundant. Can be removed.
| <PackageTags>aspnetcore</PackageTags> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <Folder Include="Properties\" /> |
| <ProjectReference Include="..\..\src\Microsoft.AspNetCore.Http.Extensions\Microsoft.AspNetCore.Http.Extensions.csproj" /> | ||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.0.0-*" /> | ||
| <PackageReference Include="xunit.runner.visualstudio" Version="2.2.0-*" /> | ||
| <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="1.2.0-*" /> |
| @@ -35,7 +35,7 @@ public void AllowsCreatingContextWithoutSettingAccessor() | |||
| var context = contextFactory.Create(new FeatureCollection()); | |||
| contextFactory.Dispose(context); | |||
| } | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
Try this:
var setupInfo = new AppDomainSetup
{
ApplicationBase = AppDomain.CurrentDomain.BaseDirectory
};
var newDomain = AppDomain.CreateDomain("new", null, setupInfo);
Tratcher
force-pushed
the
tratcher/csproj
branch
from
9675657 to
7e499be
Compare
cesarblum
reviewed
Feb 3, 2017
| <PackageReference Include="Microsoft.Extensions.TaskCache.Sources" Version="1.2.0-*" PrivateAssets="All" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <Folder Include="Properties\" /> |
Tratcher
force-pushed
the
tratcher/csproj
branch
from
7e499be to
63fa2b5
Compare
cesarblum
reviewed
Feb 3, 2017
| <PackageReference Include="Microsoft.AspNetCore.Testing" Version="1.2.0-*" /> | ||
| <PackageReference Include="xunit" Version="2.2.0-*" /> | ||
| </ItemGroup> | ||
| <ItemGroup> |
There was a problem hiding this comment.
Why? VS keeps adding it back.
There was a problem hiding this comment.
This is probably like the tabs vs spaces argument. I originally started condensing these, but now I think it's cleaner to keep package and project references in separate blocks. Plus, VS works better with it.
There was a problem hiding this comment.
..and I now realize from context, that @CesarBS is probably talking about the Service item. You can add for now, but by RTM they will remove the need for this. Keep or leave it, I don't care.
| <PackageReference Include="xunit" Version="2.2.0-*" /> | ||
| <PackageReference Include="xunit.runner.visualstudio" Version="2.2.0-*" /> | ||
| </ItemGroup> | ||
| <ItemGroup> |
| <PackageReference Include="xunit.runner.visualstudio" Version="2.2.0-*" /> | ||
| <PackageReference Include="xunit" Version="2.2.0-*" /> | ||
| </ItemGroup> | ||
| <ItemGroup> |
| <PackageReference Include="xunit.runner.visualstudio" Version="2.2.0-*" /> | ||
| <PackageReference Include="xunit" Version="2.2.0-*" /> | ||
| </ItemGroup> | ||
| <ItemGroup> |
| <PackageReference Include="xunit.runner.visualstudio" Version="2.2.0-*" /> | ||
| <PackageReference Include="xunit" Version="2.2.0-*" /> | ||
| </ItemGroup> | ||
| <ItemGroup> |
| <PackageReference Include="xunit.runner.visualstudio" Version="2.2.0-*" /> | ||
| <PackageReference Include="xunit" Version="2.2.0-*" /> | ||
| </ItemGroup> | ||
| <ItemGroup> |
| <PackageReference Include="xunit.runner.visualstudio" Version="2.2.0-*" /> | ||
| <PackageReference Include="xunit" Version="2.2.0-*" /> | ||
| </ItemGroup> | ||
| <ItemGroup> |
natemcmaster
reviewed
Feb 3, 2017
| <ProjectReference Include="..\..\src\Microsoft.AspNetCore.Http\Microsoft.AspNetCore.Http.csproj" /> | ||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.0.0-*" /> | ||
| <PackageReference Include="xunit.runner.visualstudio" Version="2.2.0-*" /> | ||
| <PackageReference Include="Microsoft.AspNetCore.Testing" Version="1.2.0-*" /> |
natemcmaster
approved these changes
Feb 3, 2017
Tratcher
force-pushed
the
tratcher/csproj
branch
from
63fa2b5 to
96f33b2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I disabled one AppDomain test I couldn't figure out. I'll file a bug for followup.