This repository was archived by the owner on Nov 20, 2018. It is now read-only.
Implement OwinEnvironment IEnumerable.GetEnumerator()
#789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kchanlee, |
JunTaoLuo
reviewed
Mar 11, 2017
| [Fact] | ||
| public void OwinEnvironmentImpelmentsGetEnumerator() | ||
| { | ||
| HttpContext context = CreateContext(); |
There was a problem hiding this comment.
style: use var whenever possible instead of the explicit type. I know that the rest of the test class doesn't follow this guideline but it's never too late to start.
Also, combine: var owinEnvironment = new OwinEnvironment(CreateContext());
| IEnumerator<KeyValuePair<string, object>> e1 = owinEnvironment.GetEnumerator(); | ||
| Assert.NotNull(e1); | ||
|
|
||
| foreach (var kv in owinEnvironment) { } // This should not throw exception |
There was a problem hiding this comment.
These checks are not really useful. It's enough to check that the enumerators are not null.
| HttpContext context = CreateContext(); | ||
| OwinEnvironment owinEnvironment = new OwinEnvironment(context); | ||
|
|
||
| IEnumerator<KeyValuePair<string, object>> e1 = owinEnvironment.GetEnumerator(); |
There was a problem hiding this comment.
Combine: Assert.NotNull(owinEnvironment.GetEnumerator());
JunTaoLuo
approved these changes
Mar 13, 2017
Tratcher
approved these changes
Mar 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
OwinEnvironmentIEnumerable.GetEnumerator()Related to Issue 788