Skip to content

Conversation

@kim-mskw
Copy link
Contributor

@kim-mskw kim-mskw commented Jul 1, 2024

Pull Request

Related Issue

Closes #270

Description

Enable the LSTM policies instead of the fully connected NN for RL in the MATD3 algorithm

Changes Proposed

Testing

Created a new environment and ran the examples and notebooks

Checklist

Please check all applicable items:

  • Code changes are sufficiently documented (docstrings, inline comments, doc folder updates)
  • New unit tests added for new features or bug fixes
  • Existing tests pass with the changes
  • Reinforcement learning examples are operational (for DRL-related changes)
  • Code tested with both local and Docker databases
  • Code follows project style guidelines and best practices
  • Changes are backwards compatible, or deprecation notices added
  • New dependencies added to pyproject.toml
  • A note for the release notes doc/release_notes.rst of the upcoming release is included
  • Consent to release this PR's code under the GNU Affero General Public License v3.0

Additional Notes (if applicable)

[Any additional information, concerns, or areas you want reviewers to focus on]

Screenshots (if applicable)

[Add screenshots to demonstrate visual changes]

mthede and others added 30 commits April 16, 2024 13:22
…ta, as evaluation runs overwrote traning runs in the visualisation
… not "example_2a_base_lstm_46": simulation name must be followed by number
…nario folder but configs can be changed for different algorithm
… filtered simulation, random subset of rl_params in table
…ecture is implemented as different case, not scenario)
…e to table "rl_params", policy updating time - not stored atm)
@codecov
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 62.58503% with 55 lines in your changes missing coverage. Please review.

Project coverage is 76.57%. Comparing base (70a70ba) to head (a7fe3cf).
Report is 219 commits behind head on main.

Files with missing lines Patch % Lines
...nforcement_learning/neural_network_architecture.py 54.63% 44 Missing ⚠️
assume/common/utils.py 28.57% 5 Missing ⚠️
assume/strategies/learning_advanced_orders.py 66.66% 3 Missing ⚠️
assume/strategies/learning_strategies.py 80.00% 2 Missing ⚠️
...einforcement_learning/algorithms/base_algorithm.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #382      +/-   ##
==========================================
- Coverage   77.00%   76.57%   -0.43%     
==========================================
  Files          48       50       +2     
  Lines        5857     5938      +81     
==========================================
+ Hits         4510     4547      +37     
- Misses       1347     1391      +44     
Flag Coverage Δ
pytest 76.57% <62.58%> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kim-mskw kim-mskw marked this pull request as ready for review July 16, 2024 19:22
@kim-mskw kim-mskw requested a review from nick-harder July 16, 2024 19:22
Copy link
Member

@nick-harder nick-harder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the nice work, looks good! I have left some comments to fix before we can merge

@nick-harder nick-harder linked an issue Jul 18, 2024 that may be closed by this pull request
@kim-mskw kim-mskw requested a review from nick-harder September 9, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add LSTM policy

5 participants