-
Notifications
You must be signed in to change notification settings - Fork 30
Lstm learning to main #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ta, as evaluation runs overwrote traning runs in the visualisation
… not "example_2a_base_lstm_46": simulation name must be followed by number
…nario folder but configs can be changed for different algorithm
…ssume into LSTM-Policies
… filtered simulation, random subset of rl_params in table
…ecture is implemented as different case, not scenario)
…23; LSTM: Ye et al. 2019)
…ssume into LSTM-Policies
…e to table "rl_params", policy updating time - not stored atm)
…ssume into LSTM-Policies
…o LSTM-Policies
…o LSTM-Policies
- fix pre commit needs
…mework/assume into LSTM-Learning-to-main
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #382 +/- ##
==========================================
- Coverage 77.00% 76.57% -0.43%
==========================================
Files 48 50 +2
Lines 5857 5938 +81
==========================================
+ Hits 4510 4547 +37
- Misses 1347 1391 +44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nick-harder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the nice work, looks good! I have left some comments to fix before we can merge
Pull Request
Related Issue
Closes #270
Description
Enable the LSTM policies instead of the fully connected NN for RL in the MATD3 algorithm
Changes Proposed
Testing
Created a new environment and ran the examples and notebooks
Checklist
Please check all applicable items:
docfolder updates)pyproject.tomldoc/release_notes.rstof the upcoming release is includedAdditional Notes (if applicable)
[Any additional information, concerns, or areas you want reviewers to focus on]
Screenshots (if applicable)
[Add screenshots to demonstrate visual changes]