Fix storage behavior #524
Merged
Fix storage behavior #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix representation of FastSeries
use previous SoC once and calculate it for all following hours correctly
fix offset in get_soc_before
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #524 +/- ##
==========================================
- Coverage 77.51% 77.49% -0.03%
==========================================
Files 50 50
Lines 6792 6802 +10
==========================================
+ Hits 5265 5271 +6
- Misses 1527 1531 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@maurerle thanks! is this ready for review? |
nick-harder
approved these changes
Jan 7, 2025
Member
|
@maurerle please also add a release note so we can keep track of updates, thanks! |
Merged
nick-harder
pushed a commit
that referenced
this pull request
Jan 15, 2025
* bidding strategies were adjusted in pypsa loader (no release notes, as this was not released) * ruff formatting * fix release notes - add missing release notes from #524
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
running:
assume -s example_01c -c dam_with_complex_opt_clearing -db "postgresql+psycopg2://assume:assume@localhost:5432/assume"previous behavior:
new behavior:
Description:
Storages were using the current SoC before, which led to always using the initial value to calculate discharge possibility.
This is fixed, by using the get_soc_before function as intended.
Also fixes debug printing of FastSeries (... ellipses was at the wrong place) and cuts of data if a timeseries index was given in FastIndex