This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Update guide for ascii-art package #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See atom/ascii-art#3 for motivation.
Motivation: copy-pasting a command which is not humanized into the command palette will result in an empty list of matches. So lets tell users what they should type.
|
Yayy! |
|
Going to merge this and atom/ascii-art#3 Monday evening (CET) if there are no other comments. |
|
Sounds good! |
izuzak
added a commit
that referenced
this pull request
Mar 16, 2015
Update guide for ascii-art package
This was referenced Mar 16, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 2 of fixing atom/ascii-art#2, you can see part 1 here: atom/ascii-art#3.
There was a bunch of small things causing problems for users following the guide step-by-step, and the guide didn't match exactly what the package generator created and what the demo package in https://github.com/atom/ascii-art looked like.
/cc @kiwitotoro @erikweibust @pbrianmackey who were discussing problems over in atom/ascii-art#2.