ESD-2054: Update rules.json to remove illegal characters from rule titles #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #213 |
faroceann
changed the title
lzychowski
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Several rules contain characters in their @title attributes that are not allowed. If a user tries to create a rule from one of these templates, they receive the error: The name of the rule. Can only contain alphanumeric characters, spaces and '-'. Can neither start nor end with '-' or spaces.
References
https://auth0team.atlassian.net/browse/ESD-2054
Testing
[ x ] This change adds test coverage for new/changed/fixed functionality
Checklist
[ x ] I have added documentation for new/changed functionality in this PR or in auth0.com/docs
[ ✓ ] All active GitHub checks for tests, formatting, and security are passing
[ ✓ ] The correct base branch is being used, if not master