Skip to content

Add GetRaw function #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2022
Merged

Add GetRaw function #2

merged 1 commit into from
Aug 18, 2022

Conversation

Draal
Copy link

@Draal Draal commented Aug 18, 2022

Description: What this PR does

Benchmark before change:

Benchmark after change:

For running benchmarks use:

go test -test.benchmem -bench JsonParser ./benchmark/ -benchtime 5s -v
# OR
make bench (runs inside docker)

mmoustai
mmoustai approved these changes Aug 18, 2022
View reviewed changes
Copy link

@mmoustai mmoustai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Draal Draal merged commit 42030fe into master Aug 18, 2022
@Draal Draal deleted the add-get-raw branch August 18, 2022 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmoustai mmoustai mmoustai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Draal @mmoustai