Skip to content

[FR] Fix some errors in example codes + fix 1 translation #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2019
Merged

[FR] Fix some errors in example codes + fix 1 translation #59

merged 2 commits into from
Jul 16, 2019

Conversation

Olyno
Copy link

@Olyno Olyno commented Jul 13, 2019

I replaced every 'voici un test d''après moi' with "voici un test d'après moi" (just an example sentence).
I fixed a translation too.
Everything about French's transltation.

@Olyno Olyno changed the title Fix some errors in example codes + fix 1 translation [FR] Fix some errors in example codes + fix 1 translation Jul 13, 2019
@novemberborn novemberborn requested a review from forresst July 14, 2019 12:48
Copy link
Collaborator

@forresst forresst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, but all AVA examples use the simple quote, so to maintain consistency in the examples, it would be better to do this:

test.serial.todo('penser à l\'écrire plus tard');

Can you change in this way?

@forresst forresst merged commit e57c768 into avajs:master Jul 16, 2019
@forresst
Copy link
Collaborator

Thank you very much for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants