Skip to content

zh_CN: test.cb.beforeEach should be test.beforeEach.cb #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2020
Merged

zh_CN: test.cb.beforeEach should be test.beforeEach.cb #65

merged 1 commit into from
Jun 9, 2020

Conversation

hubvue
Copy link
Contributor

@hubvue hubvue commented Jun 3, 2020 •
edited
Loading

I think, other languages have the same problem.

@novemberborn
Copy link
Member

Something came up and I haven’t yet had a chance to look at this.

@hubvue
Copy link
Contributor Author

hubvue commented Jun 8, 2020

Something came up and I haven’t yet had a chance to look at this.

sorry, my English is not very good. When I try to use 'test.cb.beforeEach'AP
I testing, test.cb.beforeEach is not defined. I think the API on the document does not conform to the AVA framework.

@novemberborn
Copy link
Member

Yep, nice find, thanks @hubvue!

@novemberborn novemberborn changed the title fix: test.cb.beforeEach API error, shoule be test.beforeEach.cb zh_CN: test.cb.beforeEach should be test.beforeEach.cb Jun 9, 2020
@novemberborn novemberborn merged commit b54a125 into avajs:master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hubvue @novemberborn