Skip to content

Adding translation into Spanish for 01-writting-tests #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Adding translation into Spanish for 01-writting-tests #66

merged 1 commit into from
Sep 8, 2020

Conversation

enriquezrene
Copy link
Contributor

No description provided.

@novemberborn
Copy link
Member

Thank you!

Do you know anybody who could double-check the translation? A second pair of eyes can be useful, what do you think?

@enriquezrene
Copy link
Contributor Author

Definitively, let me see if I'm able to find someone

@enriquezrene
Copy link
Contributor Author

@novemberborn, I will add @chelohidalgo as reviewer. He is a native Spanish speaker.

@enriquezrene
Copy link
Contributor Author

Actually, I can't, could you please add him?
This is his username @chelohidalgo

@novemberborn
Copy link
Member

Hi @chelohidalgo 👋 Feel free to leave comments on the PR, there's no need to officially designate you as a reviewer. (In fact, I don't think I can until you comment here.)

@chelohidalgo
Copy link

Hi @novemberborn @enriquezrene thank you so much. It looks good to me, this is new but it is ok.

Copy link

@chelohidalgo chelohidalgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@novemberborn novemberborn merged commit 4300973 into avajs:master Sep 8, 2020
@novemberborn
Copy link
Member

Thank you @enriquezrene & @chelohidalgo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants