Skip to content

Keep up to date Korean translations #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2022
Merged

Keep up to date Korean translations #75

merged 2 commits into from
Jun 27, 2022

Conversation

jopemachine
Copy link
Contributor

@jopemachine jopemachine commented Mar 29, 2022 •
edited
Loading

Thanks for this awesome project :)

Added more recipes translations for Korean.

@jopemachine jopemachine changed the title Translate typescript documentation to Korean Translate more recipes documentation to Korean Apr 3, 2022
@jopemachine jopemachine changed the title Translate more recipes documentation to Korean Translate more recipes documentations to Korean Apr 3, 2022
@novemberborn
Copy link
Member

Thanks @jopemachine!

Do you know anybody who could read through your translations? It's always good to get a second pair of eyes on things.

Let me know when you're done pushing changes and we can merge them.

@jopemachine jopemachine changed the title Translate more recipes documentations to Korean Add more translations for Korean Apr 6, 2022
@jopemachine jopemachine changed the title Add more translations for Korean Keep up to date Korean documentations Apr 30, 2022
@OctopusET
Copy link

I'm working on review.
BTW, I think it would be better to squash commits into one.

@jopemachine jopemachine force-pushed the add-typescript-ko branch from 5ef2305 to 342966e Compare May 1, 2022 00:55
@OctopusET
Copy link

Sorry for delay, review will be done within the weekend.

OctopusET
OctopusET reviewed May 9, 2022
View reviewed changes
Copy link

@OctopusET OctopusET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of translations are outdated, line breaks are reducing readability, and using transliteration good but they are not unified. It would be better to match styles.

Except for a few things mentioned above, translation seems to be fine, Thank you for your work.

@OctopusET
Copy link

For easy communication, the discussion will be in Korean. Please let me know if you have questions in English.

@novemberborn
Copy link
Member

All good @OctopusET! Thanks for the work on this.

@jopemachine
Copy link
Contributor Author

@OctopusET 상세한 리뷰 정말 감사드립니다! 지적해주신 부분들을 최대한 고쳐보았습니다. 혹시 한 번 더 리뷰 부탁드려도 될까요?

@OctopusET
Copy link

@jopemachine 네 번역 수고 많으십니다. 오늘 밤중으로 리뷰 시작해보겠습니다.

@jopemachine
Copy link
Contributor Author

@OctopusET Friendly bump :)

@OctopusET
Copy link

@jopemachine I'm sorry about the delay, I'm currently not able to review. I think I can start review on this weekend.

@OctopusET
Copy link

I'm currently working on reviewing. It will be done in two days. Sorry for delay again.

OctopusET
OctopusET reviewed Jun 21, 2022
View reviewed changes
Copy link

@OctopusET OctopusET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except some of mistake, everything is looks good.

Sorry again for long time delay, next review won't take long.

@OctopusET
Copy link

And after everything is resolved, please squash commits into one or reasonable size.

@jopemachine
Update translations
347ecdb 
Keep up to date Korean documentations

Create typescript.md

Update typescript.md

Add more recipes

Update when-to-use-plan.md

Create 01-writing-tests.md

Create 02-execution-context.md

Create 04-snapshot-testing.md

Create 03-assertions.md

Create 05-command-line.md

Update 05-command-line.md

Create 06-configuration.md

Update splitting-tests-ci.md

Fix links

Create 07-test-timeouts.md

Create 08-common-pitfalls.md

Create watch-mode.md

Create endpoint-testing.md

Update endpoint-testing.md

Create debugging-with-chrome-devtools.md

Update 01-writing-tests.md

Keep up to date READMD.md

Update readme.md

Update readme.md

Update readme.md

Update endpoint-testing.md

Fix docs

Fix docs

Update 01-writing-tests.md

Fix docs

Fix docs

Fix docs

Fix docs

Fix docs

Fix docs

Update readme.md

Update when-to-use-plan.md

Update babel.md

Update readme.md

Update 03-assertions.md

Update browser-testing.md

Update 06-configuration.md

Update 01-writing-tests.md

Update 01-writing-tests.md

Restore browser-testing.md

Remove improper spaces

Update 08-common-pitfalls.md

Remove improper spaces

Update 08-common-pitfalls.md

Update translations
OctopusET
OctopusET reviewed Jun 25, 2022
View reviewed changes
Copy link

@OctopusET OctopusET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo error that I missed last review.
Expect this it's okay to be merged.

Thank you for your work.

@jopemachine
Copy link
Contributor Author

Minor typo error that I missed last review. Expect this it's okay to be merged.

Thank you for your work.

상세한 리뷰에 다시 한 번 감사드립니다. 덕분에 휠씬 더 깔끔하고 자연스러운 번역이 될 수 있었던 것 같습니다.

@OctopusET
Copy link

@jopemachine Could you squash those commits into one? Thanks.

@novemberborn
Copy link
Member

I can squash when merging, no need to make the commit history here perfect.

@OctopusET
Copy link

okay then it's ready to be merged

@novemberborn novemberborn changed the title Keep up to date Korean documentations Keep up to date Korean translations Jun 27, 2022
@novemberborn novemberborn merged commit 65eddf1 into avajs:main Jun 27, 2022
@novemberborn
Copy link
Member

Amazing, thanks @jopemachine and @OctopusET!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OctopusET OctopusET OctopusET left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jopemachine @novemberborn @OctopusET