Skip to content

rename t.same() to t.deepEqual() #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 5, 2016
Merged

rename t.same() to t.deepEqual() #686

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
17a1e9d
WIP: rename same to deepEqual
Mar 27, 2016
ef49c0f
Update deprecation method to use `util.deprecate`
Apr 4, 2016
55cf5c9
Finish fixing all tests
Apr 4, 2016
e9a2b2a
--amend
Apr 4, 2016
4a804f7
Responding to PR comments
Apr 4, 2016
4c15c4f
Move DEPRECATED in .d.ts
Apr 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update deprecation method to use util.deprecate
  • Loading branch information
Kent C. Dodds committed Apr 4, 2016
commit ef49c0f00fdd7d3e90744559bb15711b5e3b9529
16 changes: 5 additions & 11 deletions lib/assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,17 +143,11 @@ x.ifError = x.error = function (err, msg) {
/*
* deprecated APIs
*/
x.same = function (val, expected, msg) {
deprecationNotice('same()', 'deepEqual()');
return x.deepEqual(val, expected, msg);
};

x.notSame = function (val, expected, msg) {
deprecationNotice('notSame()', 'notDeepEqual()');
return x.notDeepEqual(val, expected, msg);
};
x.same = util.deprecate(x.deepEqual, getDeprecationNotice('same()', 'deepEqual()'));
x.notSame = util.deprecate(x.notDeepEqual, getDeprecationNotice('notSame()', 'notDeepEqual()'));

function deprecationNotice(oldApi, newApi) {
console.warn(`DEPRECATION NOTICE: ${oldApi} has been renamed to ${newApi} and will eventually be removed`);
function getDeprecationNotice(oldApi, newApi) {
return `DEPRECATION NOTICE: ${oldApi} has been renamed to ${newApi} and will eventually be removed.` +
` See https://github.com/jamestalmage/ava-codemods to help upgrade your codebase automatically.`;
}