Skip to content

Range filter fix #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2019
Merged

Range filter fix #318

merged 1 commit into from
Jan 5, 2019

Conversation

pkrawat1
Copy link
Member

@pkrawat1 pkrawat1 commented Jan 5, 2019

Why?

  • Range filter boundaries cannot be reverted back once selected.
  • Due to the API returning the range boundaries depending on the params.

This change addresses the need by:

  • Uses the API's max range value, irrespective of what was selected.
  • Fixes the issue with the options integration for ng5-slider.
  • Adds custom CSS override for ng5-slider

@pkrawat1 pkrawat1 changed the base branch from master to develop January 5, 2019 18:42
@pkrawat1 pkrawat1 merged commit 60e9ec6 into develop Jan 5, 2019
@pkrawat1 pkrawat1 deleted the range-filter-fix branch January 5, 2019 18:46
pkrawat1 added a commit that referenced this pull request Sep 20, 2023
### Why?
- Range filter boundaries cannot be reverted back once selected.
- Due to the API returning the range boundaries depending on the params.

### This change addresses the need by:
- Uses the API's max range value, irrespective of what was selected.
- Fixes the issue with the options integration for ng5-slider.
- Adds custom CSS override for ng5-slider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant