Skip to content

Conversation

@vrcca
Copy link
Contributor

@vrcca vrcca commented Feb 9, 2021

Copy link
Contributor

@philss philss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you, @vrcca! 💜
I added a few minor points.

end

@doc """
This API is in preview release for Amazon Connect and is subject to change.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that they put preview APIs into the specs :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if we should update only with latest tag instead of main branch?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vrcca it's a good point. They release a new version every week. We can aim to update only with the latest tag, yes 👍

@doc """
Creates a Data Store that can ingest and export FHIR formatted data.
"""
def create_f_h_i_r_datastore(%Client{} = client, input, options \\ []) do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FHIR can be an acronym in aws-beam

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vrcca vrcca requested a review from philss February 9, 2021 18:32
philss pushed a commit to aws-beam/aws-codegen that referenced this pull request Feb 9, 2021
@philss philss merged commit f7f21be into aws-beam:master Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants