Receive use_docker flag from the cli #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnttompkins
suggested changes
Sep 14, 2020
There was a problem hiding this comment.
Is there a way to prompt for the arguments in the plugins? otherwise each argument addition will require a change to both the cloudformation cli and the plugin. Would be good to structure it in a way to where an argument addition on the plugin just means one change to the plugin.
johnttompkins
approved these changes
Sep 29, 2020
| args = sub_parser.parse_args(["-d"]) | ||
|
|
||
| assert args.language == "python36" | ||
| assert args.use_docker is True |
There was a problem hiding this comment.
nit: assert args.use_docker
| args = sub_parser.parse_args([]) | ||
|
|
||
| assert args.language == "python37" | ||
| assert args.use_docker is False |
There was a problem hiding this comment.
same here can simplify
jaymccon
approved these changes
Oct 15, 2020
| "Use docker for platform-independent packaging (Y/n)?\n", | ||
| validate_no, | ||
| "This is highly recommended unless you are experienced \n" | ||
| "with cross-platform Python packaging.", | ||
| ) | ||
|
|
||
| project.settings["use_docker"] = self._use_docker |
There was a problem hiding this comment.
We should make this useDocker for consistency with protocolVersion and JSON convention, right?
ammokhov
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add ability to consume the use docker flag from the
cloudformation-cli.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.