Move addFilter() call after addHandler()
#184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammokhov
approved these changes
Apr 19, 2022
kddejong
pushed a commit
to kddejong/cloudformation-cli-python-plugin
that referenced
this pull request
Oct 13, 2022
kddejong
pushed a commit
to kddejong/cloudformation-cli-python-plugin
that referenced
this pull request
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC:
This change avoids an issue where the
logging.getLogger().handlerslist is unconditionally subscripted with index0, which can cause anIndexErrorto be thrown if no handlers were previously defined. By moving theaddFilter()call after theaddHandler()call, this at least guaranteeshandlers[0]will have been initialized first.I've gone ahead and tested this change manually against CFN and have found no issues.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.