feat(kafka): add logic to handle delimited protobufs #4071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamorosi
requested review from
svozza and
phipag
and removed request for
svozza
svozza
previously approved these changes
Jun 19, 2025
phipag
requested changes
Jun 19, 2025
dreamorosi
force-pushed
the
test/proto-delimiters
branch
from
02cc362 to
e120b74
Compare
boring-cyborg
bot
added
the
dependencies
pull-request-size
bot
added
size/XXL
dreamorosi
changed the title
|
leandrodamascena
approved these changes
Jun 20, 2025
phipag
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR adds tests to ensure that Protobuf payloads with magic numbers are processed correctly. It also modifies slightly some types and removes unused files from the codebase.
Issue number: #4070
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.