Skip to content

Refactor recipe cloudwatch_agent config into a resource action #1993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

francesco-giordano
Copy link
Contributor

@francesco-giordano francesco-giordano commented Apr 11, 2023

Description of changes

  • Refactor recipe cloudwatch_agent config into a resource action
  • Added mock for python for redhat

Tests

  • Manually tested with kitchen on EC2 and Docker

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@francesco-giordano francesco-giordano requested review from a team as code owners April 11, 2023 15:13
@francesco-giordano francesco-giordano force-pushed the wip/cloudwatch_config branch 3 times, most recently from 3870305 to 2b1af1d Compare April 11, 2023 15:57
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #1993 (113788b) into redhat8 (46a5d74) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           redhat8    #1993   +/-   ##
========================================
  Coverage    69.01%   69.01%           
========================================
  Files           11       11           
  Lines         1588     1588           
========================================
  Hits          1096     1096           
  Misses         492      492           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@francesco-giordano francesco-giordano merged commit 4a848d7 into aws:redhat8 Apr 11, 2023
hanwen-pcluste pushed a commit to hanwen-pcluste/aws-parallelcluster-cookbook that referenced this pull request Apr 24, 2024
The checks were introduced by aws#1993 without obvious reasons. These source code files are just common source code files. And we did not have precedence checking checksum of source code files

Signed-off-by: Hanwen <[email protected]>
hanwen-pcluste pushed a commit that referenced this pull request Apr 24, 2024
The checks were introduced by #1993 without obvious reasons. These source code files are just common source code files. And we did not have precedence checking checksum of source code files

Signed-off-by: Hanwen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants