-
Notifications
You must be signed in to change notification settings - Fork 90
3.0: Merge wip/pcluster3 into develop #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove jobwatcher, sqswatcher and nodewatcher code. * Remove nodewatcher, sqswatcher, jobwatcher references. * Remove ASG utilities. Signed-off-by: Enrico Usai <[email protected]>
Signed-off-by: Enrico Usai <[email protected]>
Signed-off-by: Enrico Usai <[email protected]>
Signed-off-by: Enrico Usai <[email protected]>
Signed-off-by: Enrico Usai <[email protected]>
* Change tag prefix from 'aws-parallelcluster-' to 'parallelcluster:' Signed-off-by: Rex <[email protected]>
custom-bucket # bucket selected by user for custom artifacts └── parallelcluster └── 3.0.0 # new folder ├── cli # uploaded by uploadCLI.sh script │ └── aws-parallelcluster-3.0.0.tgz ├── cookbooks # uploaded by uploadCookbok.sh script │ └── aws-parallelcluster-cookbook-3.0.0.* └── node # uploaded by uploadNode.sh script └── aws-parallelcluster-node-3.0.0.* Signed-off-by: Enrico Usai <[email protected]>
…tom developer bucket.
The benefit of this change is that TerminateInstances permissions do not need to be included in the instance profile attached to compute nodes. In order for this to work instances must be configured to terminate upon instance-initiated shutdown (as opposed to stopping, which is the default behavior). Signed-off-by: Tim Lane <[email protected]>
Signed-off-by: chenwany <[email protected]>
This reverts commit 5c7dcff.
Signed-off-by: chenwany <[email protected]>
Apply rename tag ClusterName to parallelcluster:cluster-name Apply change tag prefix to 'parallelcluster:' Signed-off-by: chenwany <[email protected]>
Apply the changes in "Drop deprecated features and use inclusive language" after clustermgtd refactor Signed-off-by: chenwany <[email protected]>
…stead of TerminateInstances" Signed-off-by: chenwany <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #316 +/- ##
============================================
+ Coverage 61.98% 77.88% +15.89%
============================================
Files 23 12 -11
Lines 2533 1605 -928
============================================
- Hits 1570 1250 -320
+ Misses 963 355 -608
Continue to review full report at Codecov.
|
0924488
to
80ad27c
Compare
…eaddr on power_down Signed-off-by: chenwany <[email protected]>
80ad27c
to
cd5f577
Compare
Signed-off-by: Enrico Usai <[email protected]> # Conflicts: # CHANGELOG.md # amis/build_ami.sh # amis/packer_alinux2.json # amis/packer_centos7.json # amis/packer_centos8.json # amis/packer_ubuntu1804.json # amis/packer_ubuntu2004.json # amis/packer_variables.json # attributes/conditions.rb # attributes/default.rb # files/default/configure-pat.sh # libraries/helpers.rb # metadata.rb # recipes/cluster_admin_user_install.rb # recipes/fsx_mount.rb # recipes/sge_install.rb # recipes/slurm_install.rb # recipes/tests.rb # templates/default/compute_ready.erb # templates/default/slurm/slurm.conf.erb
cd5f577
to
5004513
Compare
demartinofra
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch includes all the changes from wip/pcluster3 branch plus the following changes:
Cherry-pick: Use subprocess based method to read shared files - see 22c7e21
Cherry pick: computemgtd: do not fail on config reload - see eb1cf0d