Skip to content

Fix matchers to align with waiters SEP #3242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 21, 2025
Merged

Fix matchers to align with waiters SEP #3242

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
09a0037
Add examples of currently failing cases
richardwang1124 May 5, 2025
3cea830
Remove puts
richardwang1124 May 5, 2025
bb1035d
Rever poller changes
richardwang1124 May 5, 2025
a0ceb63
Add changelog entry
richardwang1124 May 5, 2025
2f78a8a
Add more test cases for path matchers
richardwang1124 May 8, 2025
9ce40ea
Preprocess object expected values
richardwang1124 May 9, 2025
42bc4bc
Changelog message update
richardwang1124 May 9, 2025
92a351a
Make compatible with older ruby versions
richardwang1124 May 9, 2025
4a97252
Changes from PR comments
richardwang1124 May 16, 2025
1b44334
Remove table concepts from tests
richardwang1124 May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove puts
  • Loading branch information
@richardwang1124
richardwang1124 committed May 5, 2025
commit 3cea830cdad4184ec1998e6fc3cc5e6794ba24bb
3 changes: 0 additions & 3 deletions gems/aws-sdk-core/lib/aws-sdk-core/waiters/poller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,6 @@ def acceptor_matches?(acceptor, response)
def matches_path?(acceptor, response)
if response.data
result = JMESPath.search(path(acceptor), response.data)
puts result
puts 'vs'
puts acceptor['expected']
result == acceptor['expected']
else
false
Expand Down
Loading