Skip to content

Upgrade reference to AWS SDK for .NET to the recently GA V4 version. #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 1, 2025

Conversation

normj
Copy link
Member

@normj normj commented May 1, 2025

Description of changes:
The AWS SDK for .NET recently GA the V4 version. https://aws.amazon.com/blogs/developer/general-availability-of-aws-sdk-for-net-v4-0/

Updating this package to V4 unblocks users like this one aws/aws-sdk-net#3362 (comment) to move their application to V4.

The V4 is an evolutionary major version and we are expecting users to update fairly quickly and relatively short cycle of dual support with V3.

I made the version bump a major version bump since it forces users to update to V4 of the SDK.

Testing
I ran the tests in the solution and scanned the SDK usage for possible null collection issues. In V4 collection properties default to null. Only area I saw that could be a problem was in the GetVersion method of SecretCacheItem which already had a null check so was safe.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@normj normj requested a review from a team as a code owner May 1, 2025 00:18
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.52%. Comparing base (befeea6) to head (4ae8437).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #169   +/-   ##
=======================================
  Coverage   72.52%   72.52%           
=======================================
  Files           6        6           
  Lines         222      222           
  Branches       23       23           
=======================================
  Hits          161      161           
  Misses         52       52           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@simonmarty simonmarty dismissed stale reviews from ThirdEyeSqueegee and themself via 4ae8437 May 1, 2025 17:22
@simonmarty simonmarty merged commit 212ac35 into aws:master May 1, 2025
1 check passed
@simonmarty
Copy link
Contributor

Released as 2.0.0. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants